gtk4.git
22 years agoRemove an extraneous unref. (#122336, Frederic Crozat)
Matthias Clasen [Sun, 5 Oct 2003 22:00:49 +0000 (22:00 +0000)]
Remove an extraneous unref. (#122336, Frederic Crozat)

Sun Oct  5 23:59:03 2003  Matthias Clasen  <maclas@gmx.de>

* tests/testsocket.c (child_read_watch): Remove an
        extraneous unref.  (#122336, Frederic Crozat)

22 years agoTrim whitespace in "visible-window" blurb. (#123910, Christian Rose)
Matthias Clasen [Sun, 5 Oct 2003 20:39:17 +0000 (20:39 +0000)]
Trim whitespace in "visible-window" blurb. (#123910, Christian Rose)

Sun Oct  5 22:38:22 2003  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkeventbox.c (gtk_event_box_class_init): Trim whitespace in
"visible-window" blurb.  (#123910, Christian Rose)

22 years agoUpdated Japanese translation.
KAMAGASAKO Masatoshi [Sun, 5 Oct 2003 14:45:16 +0000 (14:45 +0000)]
Updated Japanese translation.

2003-10-05  KAMAGASAKO Masatoshi  <emerald@gnome.gr.jp>

* ja.po: Updated Japanese translation.

22 years agofocus arrow before pack_end items (#123851, Matthias Clasen)
Soeren Sandmann [Sat, 4 Oct 2003 22:58:14 +0000 (22:58 +0000)]
focus arrow before pack_end items (#123851, Matthias Clasen)

Sun Oct  5 00:53:15 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktoolbar.c (gtk_toolbar_list_children_in_focus_order):
focus arrow before pack_end items (#123851, Matthias Clasen)

22 years agoUpdated Serbian translation.
Danilo Šegan [Sat, 4 Oct 2003 20:14:08 +0000 (20:14 +0000)]
Updated Serbian translation.

2003-10-04  Danilo Šegan  <dsegan@gmx.net>

* sr.po, sr@Latn.po: Updated Serbian translation.

22 years agoUpdated Swedish translation somewhat.
Christian Rose [Sat, 4 Oct 2003 19:45:37 +0000 (19:45 +0000)]
Updated Swedish translation somewhat.

2003-10-04  Christian Rose  <menthos@menthos.com>

* sv.po: Updated Swedish translation somewhat.

22 years agoAdded missing files.
Christian Rose [Sat, 4 Oct 2003 15:59:41 +0000 (15:59 +0000)]
Added missing files.

2003-10-04  Christian Rose  <menthos@menthos.com>

* POTFILES.in: Added missing files.

22 years agoUpdated Serbian translation.
Danilo Šegan [Sat, 4 Oct 2003 01:33:59 +0000 (01:33 +0000)]
Updated Serbian translation.

2003-10-04  Danilo Šegan  <dsegan@gmx.net>

* sr.po, sr@Latn.po: Updated Serbian translation.

22 years agoonly set the model on ->priv->cell_view if ->priv->cell_view is non-NULL.
Kristian Rietveld [Fri, 3 Oct 2003 18:56:24 +0000 (18:56 +0000)]
only set the model on ->priv->cell_view if ->priv->cell_view is non-NULL.

Fri Oct  3 20:50:48 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkcombobox.c (gtk_combo_box_set_model): only set the model
on ->priv->cell_view if ->priv->cell_view is non-NULL.

* gtk/gtkcomboboxentry.c: include gtkintl.h, add text_renderer
field to GtkComboBoxEntryPrivate,
(gtk_combo_box_entry_class_init), (gtk_combo_box_entry_init),
(gtk_combo_box_entry_set_property), (gtk_combo_box_entry_get_property),
(gtk_combo_box_entry_set_text_column), (gtk_combo_box_entry_new): add
a construct-only "text_column" property and reorder code to use it
and support inheriting this widget.

22 years agofix menu delays
cinamod [Fri, 3 Oct 2003 18:17:39 +0000 (18:17 +0000)]
fix menu delays

22 years agoredo how we do styles
cinamod [Fri, 3 Oct 2003 17:02:45 +0000 (17:02 +0000)]
redo how we do styles

22 years agocatch color changes properly now
cinamod [Fri, 3 Oct 2003 16:20:25 +0000 (16:20 +0000)]
catch color changes properly now

22 years agocatch theme and color changes
cinamod [Fri, 3 Oct 2003 15:54:20 +0000 (15:54 +0000)]
catch theme and color changes

22 years agodon't leak as many GCs
cinamod [Fri, 3 Oct 2003 13:51:41 +0000 (13:51 +0000)]
don't leak as many GCs

22 years agoAdded API doc comments.
Kristian Rietveld [Thu, 2 Oct 2003 21:30:11 +0000 (21:30 +0000)]
Added API doc comments.

Thu Oct  2 23:28:02 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkcombobox.c: Added API doc comments.

* gtk/gtkcomboboxentry.c: Ditto.

22 years agoDoc tweaks-
Matthias Clasen [Wed, 1 Oct 2003 22:53:57 +0000 (22:53 +0000)]
Doc tweaks-

22 years agoAdd gtkcellview.h and gtkcellviewmenuitem.h.
Matthias Clasen [Wed, 1 Oct 2003 22:43:30 +0000 (22:43 +0000)]
Add gtkcellview.h and gtkcellviewmenuitem.h.

2003-10-02  Matthias Clasen  <maclas@gmx.de>

* gtk/Makefile.am (IGNORE_HFILES): Add gtkcellview.h and
gtkcellviewmenuitem.h.

* gtk/tmpl/gtkentrycompletion.sgml:
* gtk/tmpl/gtktreemodelfilter.sgml:
* gtk/tmpl/gtkcelllayout.sgml:
* gtk/tmpl/gtkcombobox.sgml:
* gtk/tmpl/gtkcomboboxentry.sgml: New templates.

* gtk/gtk-sections.txt:
* gtk/gtk-docs.sgml: Add sections for GtkEntryCompletion,
GtkTreeModelFilter, GtkCellLayout, GtkComboBox, GtkComboBoxEntry.

* gtk/tmpl/gtktreednd.sgml: Add short description.

* gtk/gtk-docs.sgml: Move GtkItemFactory to the "Deprecated" chapter.

* gtk/tmpl/gtktoggletoolbutton.sgml: Fix section title.

22 years agoSimplify with a macro. This bloats the compiled code, but at least it
Federico Mena Quintero [Wed, 1 Oct 2003 21:40:17 +0000 (21:40 +0000)]
Simplify with a macro. This bloats the compiled code, but at least it

2003-10-01  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (name_sort_func): Simplify with a
macro.  This bloats the compiled code, but at least it makes the
human-readable code not egregiously ugly.
(size_sort_func): Likewise.
(mtime_sort_func): Likewise.

22 years agoimplement the GtkCellLayout interface, drop packing/attribute/cell data
Kristian Rietveld [Wed, 1 Oct 2003 20:51:54 +0000 (20:51 +0000)]
implement the GtkCellLayout interface, drop packing/attribute/cell data

Wed Oct  1 22:43:40 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkcellview.[ch]: implement the GtkCellLayout interface, drop
packing/attribute/cell data functions from the header,
(gtk_cell_view_set_cell_data): added support for cell data funcs.

* gtk/gtkcombobox.[ch]: implement the GtkCellLayout interface, drop
packing/attribute/cell data functions from the header, implemented
cell data func support.

* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_new): updated
for the move to GtkCellLayout.

* tests/testcombo.c (create_combo_box_grid_demo), (main): ditto.

22 years agobe more protective about when we install properties
cinamod [Wed, 1 Oct 2003 20:49:44 +0000 (20:49 +0000)]
be more protective about when we install properties

22 years agoUse enum values instead of plain numbers for the file lists's sort
Federico Mena Quintero [Wed, 1 Oct 2003 19:42:50 +0000 (19:42 +0000)]
Use enum values instead of plain numbers for the file lists's sort

2003-10-01  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (tree_selection_changed): Use enum
values instead of plain numbers for the file lists's sort columns.
(create_file_list): Likewise.
(tree_selection_changed): Make the file list start up sorted by
name, and don't specify a default sorting function, so that there
is no unsorted order.  This is for consistency with Nautilus.
(list_sort_column_changed_cb): Callback; we cache whether the sort
order for the file list's name column is ascending or not.
(compare_with_folders_first): New helper function to sort
directories before files.
(name_sort_func): Use compare_with_folders_first().
(size_sort_func): Likewise.
(mtime_sort_func): Likewise.

Of course this callback mess would be easy in a real language:

  (set-sort-func sortable NAME_COLUMN
    (make-comparer impl (lambda (a b) (strcmp (get-name a) (get-name b)))))
  (set-sort-func sortable SIZE_COLUMN
    (make-comparer impl (lambda (a b) (compare (get-size a) (get-size b)))))
  ... etc ...

  (define (make-comparer impl f)
    (lambda (a b)
      (if (eq (is-dir? a) (is-dir? b))
          (f a b)
  (if (sort-ascending? impl)
      (if (is-dir? a) -1 1)
      (if (is-dir? a) 1 -1)))))

22 years agoIntroduce a separate "hide_if_empty" property for empty menu handling.
Matthias Clasen [Wed, 1 Oct 2003 19:07:36 +0000 (19:07 +0000)]
Introduce a separate "hide_if_empty" property for empty menu handling.

2003-10-01  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkaction.c (gtk_action_class_init):
(gtk_action_[gs]et_property): Introduce a separate
"hide_if_empty" property for empty menu handling.
(_gtk_action_sync_menu_visible): ...and use it here.

* tests/testmerge.c (main): ...and here.

22 years agoAdded fields for the shortcuts tree and its model. (create_file_list):
Federico Mena Quintero [Wed, 1 Oct 2003 00:53:59 +0000 (00:53 +0000)]
Added fields for the shortcuts tree and its model. (create_file_list):

2003-09-30  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (struct _GtkFileChooserImplDefault):
Added fields for the shortcuts tree and its model.
(create_file_list): Don't call
gtk_tree_view_column_set_sort_column_id() twice.
(create_shortcuts_model): New function.
(list_icon_data_func): Use an ICON_SIZE macro instead of a
hardcoded value.
(list_row_activated): Use _gtk_file_chooser_set_current_folder_path()
to avoid converting the GtkFilePath to a URI string.
(gtk_file_chooser_impl_default_set_current_folder): Select the
appropriate item from the shortcuts list when the current folder
changes, to let the user know where he is.
(tree_selection_changed): Likewise.

* gtkfilesystem.h (struct _GtkFileSystemIface): Added methods for
::supports_shortcuts(), ::list_shortcuts(), ::set_shortcuts().

22 years agoFix signal doc comments to pacify gtk-doc.
Matthias Clasen [Wed, 1 Oct 2003 00:16:11 +0000 (00:16 +0000)]
Fix signal doc comments to pacify gtk-doc.

* gtk/gtktoolitem.c (gtk_tool_item_class_init): Fix signal doc
comments to pacify gtk-doc.

22 years agoAdd two missing signals.
Matthias Clasen [Tue, 30 Sep 2003 23:25:48 +0000 (23:25 +0000)]
Add two missing signals.

* gdk/tmpl/keys.sgml: Add two missing signals.

22 years agoDoc formatting tweaks.
Matthias Clasen [Tue, 30 Sep 2003 22:48:10 +0000 (22:48 +0000)]
Doc formatting tweaks.

2003-10-01  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkmain.c: Doc formatting tweaks.

* gtk/gtktoolitem.c (gtk_tool_item_set_is_important): Fix a typo.

* gtk/gtkcheckmenuitem.h (gtk_check_menu_item_set_draw_as_radio):
Use the same parameter names as in .c file, to pacify gtk-doc.

* gtk/gtktoggletoolbutton.[hc]:
* gtk/gtktoolbutton.[hc]:
* gtk/gtktoolitem.[hc]:
* gtk/gtktoolbar.[hc]:
* gtk/gtkcolorbutton.[hc]:
* gtk/gtkfontbutton.[hc]:
* gtk/gtkalignment.[hc]: Define GET_PRIVATE macros in the
source, not in the header.

* gtk/gtkcheckmenuitem.c (gtk_check_menu_item_[sg]et_draw_as_radio):
Document these as 2.4 API additions.

* gtk/tmpl/gtkaction.sgml: Fix cross reference to GtkMenuMerge.

* gtk/gtk-sections.txt: Additions.

* gtk/tmpl/gtkitemfactory.sgml: Add hint to use #GtkUIManager instead.

22 years agoAdd API doc comments.
Kristian Rietveld [Tue, 30 Sep 2003 21:44:39 +0000 (21:44 +0000)]
Add API doc comments.

Tue Sep 30 23:42:56 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkentry.c (gtk_entry_set_completion),
(gtk_entry_get_completion): Add API doc comments.

* gtk/gtkentrycompletion.c: Fix #includes and add API doc comments.

22 years agoAdd hint to use #GtkUIManager instead.
Matthias Clasen [Tue, 30 Sep 2003 21:15:00 +0000 (21:15 +0000)]
Add hint to use #GtkUIManager instead.

* gtk/tmpl/gtkitemfactory.sgml: Add hint to use #GtkUIManager instead.

22 years agoAdd "Since: 2.4" to all API doc comments.
Kristian Rietveld [Tue, 30 Sep 2003 21:14:09 +0000 (21:14 +0000)]
Add "Since: 2.4" to all API doc comments.

Tue Sep 30 23:12:34 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtktreemodelfilter.c: Add "Since: 2.4" to all API doc comments.

22 years agoSome API doc comment fixes.
Kristian Rietveld [Tue, 30 Sep 2003 21:02:05 +0000 (21:02 +0000)]
Some API doc comment fixes.

Tue Sep 30 22:59:58 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtktreeviewcolumn.c: Some API doc comment fixes.

* gtk/gtkcellayout.c: Fix #include and oooooh API doc comments!

22 years agoTest handling of empty menus.
Matthias Clasen [Tue, 30 Sep 2003 20:55:24 +0000 (20:55 +0000)]
Test handling of empty menus.

2003-09-30  Matthias Clasen  <maclas@gmx.de>

* tests/merge-*.ui:
* tests/testmerge.c: Test handling of empty menus.

* gtk/gtkuimanager.c (_gtk_menu_is_empty): New function to determine
whether a menu is empty. Used in gtkaction.c.
(update_smart_separators): Also update the visibility of empty menus.
(update_node): When creating a new menu proxy, insert an "Empty" menu
item which only gets shown if the menu is empty.

* gtk/gtkaction.c (gtk_action_class_init): Document the meaning of
"is_important" for menu proxies.
(_gtk_action_sync_menu_visible): New function to sync the visibility
of menu proxies. Used in gtkuimanager.c.
(gtk_action_sync_visible): New function to sync the visibility of
proxies.

22 years agoset popup_in_progress to TRUE, (gtk_combo_box_menu_show): and back to
Kristian Rietveld [Tue, 30 Sep 2003 19:46:48 +0000 (19:46 +0000)]
set popup_in_progress to TRUE, (gtk_combo_box_menu_show): and back to

Tue Sep 30 21:43:34 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): set
popup_in_progress to TRUE,
(gtk_combo_box_menu_show): and back to FALSE here; the menu now
won't disappear on the first button release. (Reported by Matthias
Clasen).

22 years agoactually show the child.
Kristian Rietveld [Tue, 30 Sep 2003 19:11:55 +0000 (19:11 +0000)]
actually show the child.

Tue Sep 30 21:08:43 2003  Kristian Rietveld  <kris@gtk.org>

* gtk/gtkcombobox.c (gtk_combo_box_init): actually show the child.

* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init): ditto. (#123543,
Marco Pesenti Gritti).

22 years agoThe render vfunc takes a GdkDrawable* instead of a GdkWindow*, because
Murray Cumming [Tue, 30 Sep 2003 17:10:02 +0000 (17:10 +0000)]
The render vfunc takes a GdkDrawable* instead of a GdkWindow*, because

2003-09-30  Murray Cumming  <murrayc@usa.net>

        * gtk/gtkcellrenderer.h: The render vfunc takes a GdkDrawable*
        instead of a GdkWindow*, because that what it is given. The
        documentation was already correct. This should cause no API/ABI
        breakage with C compilers.
        * gtk/gtkcellrenderertext.c, gtkcellrendererpixbuf.c,
        gtkcellrenderertogger.c: Updated the declarations of the render vfunc
        implementation accordingly.

22 years agoApplied revision by Augusta Marques da Silva <augusta.marques@gmx.net>.
Gustavo Maciel Dias Vieira [Tue, 30 Sep 2003 15:32:06 +0000 (15:32 +0000)]
Applied revision by Augusta Marques da Silva <augusta.marques@gmx.net>.

2003-09-30  Gustavo Maciel Dias Vieira  <gdvieira@zaz.com.br>

        * pt_BR.po: Applied revision by Augusta Marques da Silva
        <augusta.marques@gmx.net>.

22 years agoadd gtksetting
cinamod [Tue, 30 Sep 2003 14:44:11 +0000 (14:44 +0000)]
add gtksetting

22 years agoDocument the "direction-changed" and "keys-changed" signals.
Matthias Clasen [Tue, 30 Sep 2003 00:36:29 +0000 (00:36 +0000)]
Document the "direction-changed" and "keys-changed" signals.

2003-09-30  Matthias Clasen  <maclas@gmx.de>

* gdk/gdkkeys.c (gdk_keymap_class_init): Document the
"direction-changed" and "keys-changed" signals.

* gdk/gdkscreen.c (gdk_screen_class_init): Document the
"size-changed" signal.

* gdk/gdkdisplaymanager.c (gdk_display_manager_class_init):
Document the "display-opened" signal.

* gdk/gdkdisplay.c (gdk_display_close): Doc tweak.
(gdk_display_class_init): Document the "closed" signal.

* gdk/tmpl/keys.sgml: Small addition.

* gdk/gdk-sections.txt: Add GdkDisplayClass and GdkScreenClass.

* gdk-pixbuf/gdk-pixbuf-sections.txt: Add GdkPixbufLoaderClass.

22 years agoAdd GdkPixbufLoaderClass.
Matthias Clasen [Mon, 29 Sep 2003 23:27:41 +0000 (23:27 +0000)]
Add GdkPixbufLoaderClass.

* gdk-pixbuf/gdk-pixbuf-sections.txt: Add GdkPixbufLoaderClass.

22 years agorename property tab_moves_focus to accepts_tab. (#122709 again).
Soeren Sandmann [Sat, 27 Sep 2003 14:13:12 +0000 (14:13 +0000)]
rename property tab_moves_focus to accepts_tab. (#122709 again).

Sat Sep 27 16:02:40 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktextview.[ch]: rename property tab_moves_focus to
accepts_tab. (#122709 again).

22 years agoDocument the fact that the newly created object does not come with a
Matthias Clasen [Sat, 27 Sep 2003 00:42:20 +0000 (00:42 +0000)]
Document the fact that the newly created object does not come with a

2003-09-27  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkwindow.c (gtk_window_new):
* gtk/gtkitemfactory.c (gtk_item_factory_new): Document
the fact that the newly created object does not come with
a floating reference.  (#103068, patch by Frederic Lespez)

22 years agoDeprecate GtkItemFactory in favor of GtkUIManager. Just leave
Matthias Clasen [Fri, 26 Sep 2003 23:59:42 +0000 (23:59 +0000)]
Deprecate GtkItemFactory in favor of GtkUIManager. Just leave

2003-09-27  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkitemfactory.h: Deprecate GtkItemFactory in favor
of GtkUIManager. Just leave GtkTranslateFunc undeprecated,
since GtkActionGroup uses it.

22 years agoTurn off GTK_DISABLE_DEPRECATED, since this test uses the
Matthias Clasen [Fri, 26 Sep 2003 23:33:46 +0000 (23:33 +0000)]
Turn off GTK_DISABLE_DEPRECATED, since this test uses the

2003-09-27  Matthias Clasen  <maclas@gmx.de>

* tests/testtext.c: Turn off GTK_DISABLE_DEPRECATED, since
this test uses the soon-to-be-deprecated GtkItemFactory.

* demos/gtk-demo/Makefile.am (demos): Add ui_manager.c,
remove item_factory.c

* demos/gtk-demo/ui_manager.c: Duplicate of item_factory.c
using GtkUIManager instead of GtkItemFactory.

22 years agoDemonstrate the use of the connect-proxy signal.
Matthias Clasen [Fri, 26 Sep 2003 23:01:32 +0000 (23:01 +0000)]
Demonstrate the use of the connect-proxy signal.

2003-09-27  Matthias Clasen  <maclas@gmx.de>

* tests/testmerge.c: Demonstrate the use of the
connect-proxy signal.

* gtk/gtkaction.c (connect_proxy): Add connect-proxy and
disconnect-proxy signals to do small customizations
like displaying tooltips in the statusbar without
custom actions.  (#122894, Philip Langdale)

* gtk/gtkuimanager.c (update_node): Don't leak tooltip.

22 years agoLanding the new ComboBox. Note that only gtkcombobox.h and
Kristian Rietveld [Fri, 26 Sep 2003 21:57:06 +0000 (21:57 +0000)]
Landing the new ComboBox. Note that only gtkcombobox.h and

Fri Sep 26 23:49:44 2003  Kristian Rietveld  <kris@gtk.org>

Landing the new ComboBox. Note that only gtkcombobox.h and
gtkcomboboxentry.h are public.

* gtk/gtkcellview.[ch], gtk/gtkcellviewmenuitem.[ch],
gtk/gtkcombobox.[ch], gtk/gtkcomboboxentry.[ch]: new files.

* gtk/Makefile.am, gtk/gtk.h: adding the new files.

* tests/testcombo.c: and a new test.

* tests/Makefile.am: adding the new test.

22 years agoDon't use hardcoded DEMOCODEDIR on Windows.
Tor Lillqvist [Thu, 25 Sep 2003 18:48:06 +0000 (18:48 +0000)]
Don't use hardcoded DEMOCODEDIR on Windows.

2003-09-25  Tor Lillqvist  <tml@iki.fi>

* demos/gtk-demo/main.c: Don't use hardcoded DEMOCODEDIR on Windows.

2003-09-21  Tor Lillqvist  <tml@iki.fi>

* gdk/win32/gdkevents-win32.c (handle_wm_paint): New
function. Code split out from gdk_event_translate(). Needed
because gdk_event_get_graphics_expose() couldn't do anything
sensible otherwise. (Not that I think graphics exposes work anyway
in gdk/win32, but at least now the code could work.)

(gdk_event_get_graphics_expose): Call handle_wm_paint() instead of
gdk_event_translate(), which couldn't have worked as it doesn't
take any pre-allocated GdkEvent parameter any longer.

(gdk_event_translate): Handle WM_MOUSEACTIVATE: Don't let
GDK_WINDOW_TEMP windows be activated. (#122578, John Ehresman)

22 years agoset delay on popdown menus
cinamod [Thu, 25 Sep 2003 15:07:02 +0000 (15:07 +0000)]
set delay on popdown menus

22 years agoset delay on popdown menus
cinamod [Thu, 25 Sep 2003 15:04:16 +0000 (15:04 +0000)]
set delay on popdown menus

22 years agoUpdated Japanese translation.
KAMAGASAKO Masatoshi [Wed, 24 Sep 2003 16:58:53 +0000 (16:58 +0000)]
Updated Japanese translation.

2003-09-25  KAMAGASAKO Masatoshi  <emerald@gnome.gr.jp>

* ja.po: Updated Japanese translation.

22 years agoDemonstrate tooltips on toolitems.
Matthias Clasen [Tue, 23 Sep 2003 23:55:02 +0000 (23:55 +0000)]
Demonstrate tooltips on toolitems.

2003-09-24  Matthias Clasen  <maclas@gmx.de>

* demos/gtk-demo/appwindow.c (do_appwindow): Demonstrate tooltips
on toolitems.

22 years agoSync tooltips on toolitems.
Matthias Clasen [Tue, 23 Sep 2003 23:42:39 +0000 (23:42 +0000)]
Sync tooltips on toolitems.

2003-09-24  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkaction.c (connect_proxy): Sync tooltips on toolitems.

* gtk/gtkuimanager.c (update_node): Don't complain about missing
actions on popups. Re-set "tooltip" property on toolitems after
adding them to parent to trigger proxy update.

22 years agoconst some strings
cinamod [Mon, 22 Sep 2003 14:36:30 +0000 (14:36 +0000)]
const some strings

22 years agoInitially activate the JUSTIFY_RIGHT group member to test the fix for
Matthias Clasen [Mon, 22 Sep 2003 08:54:23 +0000 (08:54 +0000)]
Initially activate the JUSTIFY_RIGHT group member to test the fix for

2003-09-22  Matthias Clasen  <maclas@gmx.de>

* tests/testmerge.c (main): Initially activate the JUSTIFY_RIGHT
group member to test the fix for #122904.

* gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full):
Add the action to the group before activating it, otherwise we
may end up with multiple active group members.  (#122904, Marco
Pesenti Gritti)

22 years agoFix a copy-and-paste error. (#122800)
Matthias Clasen [Mon, 22 Sep 2003 08:30:26 +0000 (08:30 +0000)]
Fix a copy-and-paste error. (#122800)

2003-09-22  Matthias Clasen  <maclas@gmx.de>

* gtk/tmpl/gtktable.sgml: Fix a copy-and-paste error.  (#122800)

22 years agoChanges to make cross-process merging feasible:
Matthias Clasen [Sun, 21 Sep 2003 22:04:48 +0000 (22:04 +0000)]
Changes to make cross-process merging feasible:

2003-09-21  Matthias Clasen  <maclas@gmx.de>

Changes to make cross-process merging feasible:

* gtk/gtkuimanager.[hc]: Add a readonly "ui" property which holds the
merged UI definition. Remove the "changed" signal, since its role
is now filled by "notify::ui". Instead add a "actions-changed" signal
which gets emitted when the set of actions changes.

* gtk/gtktoggleactionprivate.h:
* gtk/gtktoggleaction.[hc] (gtk_toggle_action_[sg]et_draw_as_radio):
Add a "draw_as_radio" property to toggle actions so that they can be
used as proxies for radio actions much like the "draw_as_radio"
property on check menu items enables them to operate as proxies for
radio actions.

Prevent the "show_all" trap for action-based menus (see
http://mail.gnome.org/archives/gtk-devel-list/2003-September/
msg00260.html):

* gtk/gtkmenu.c (gtk_menu_{hide,show}_all): Remove g_return_if_fail()
calls from static functions.

* gtk/gtkuimanager.c (update_node):
* gtk/gtkaction.c (connect_proxy): Set "no_show_all" on constructed
widgets whose visibility is externally controlled.

* gtk/gtkwidget.[hc] (gtk_widget_[gs]et_no_show_all): Add a boolean
"no_show_all" property with setter and getter. When TRUE, it keeps
gtk_widget_{hide,show}_all() from modifying the visibility of the
widget and its children.

22 years agoAdd new "tab moves focus" property (#122709)
Soeren Sandmann [Sun, 21 Sep 2003 21:17:44 +0000 (21:17 +0000)]
Add new "tab moves focus" property (#122709)

Sun Sep 21 23:13:37 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktextview.[ch]: Add new "tab moves focus" property (#122709)

22 years agoDon't use zip -r on the etc directory, to avoid including editor backup
Tor Lillqvist [Sat, 20 Sep 2003 23:52:16 +0000 (23:52 +0000)]
Don't use zip -r on the etc directory, to avoid including editor backup

2003-09-20  Tor Lillqvist  <tml@iki.fi>

* gtk-zip.sh.in: Don't use zip -r on the etc directory, to avoid
including editor backup files. List files we want explicitly.

* gtk/gtkmain.c (_gtk_get_lc_ctype): New function. On Unix, just
calls setlocale (LC_CTYPE, NULL). On Windows, looks for the
LC_ALL, LC_CTYPE and LANG environment variables, than calls
g_win32_getlocale().

(gtk_get_default_language): Code snippet moved to above function,
call it.

* gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave)
* gtk/gtkrc.c (gtk_rc_context_parse_file): Call
_gtk_get_lc_ctype() instead of setlocale().

22 years ago0.4.3
Raymond Penners [Sat, 20 Sep 2003 09:56:27 +0000 (09:56 +0000)]
0.4.3

22 years agoRemove a pointless check. (#122710, Kjartan Maraas)
Matthias Clasen [Fri, 19 Sep 2003 19:20:09 +0000 (19:20 +0000)]
Remove a pointless check. (#122710, Kjartan Maraas)

2003-09-19  Matthias Clasen  <maclas@gmx.de>

* io-tga.c (try_preload): Remove a pointless check.
(#122710, Kjartan Maraas)

22 years agoimplement RTL flipping (#96632)
Soeren Sandmann [Fri, 19 Sep 2003 16:18:16 +0000 (16:18 +0000)]
implement RTL flipping (#96632)

Fri Sep 19 18:15:31 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtkpaned.c, gtk/gtkhpaned.c: implement RTL flipping
(#96632)

22 years agoImprove documentation. (#117306, Steve Chaplin)
Soeren Sandmann [Fri, 19 Sep 2003 11:29:10 +0000 (11:29 +0000)]
Improve documentation. (#117306, Steve Chaplin)

Fri Sep 19 13:24:54 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktreeview.c (gtk_tree_view_get_cursor): Improve
documentation. (#117306, Steve Chaplin)

22 years agoUpdated French translation.
Christophe Merlet [Fri, 19 Sep 2003 09:39:59 +0000 (09:39 +0000)]
Updated French translation.

22 years agoHandle dead keysyms present on the US-International keyboard. For clarity,
Tor Lillqvist [Fri, 19 Sep 2003 00:30:35 +0000 (00:30 +0000)]
Handle dead keysyms present on the US-International keyboard. For clarity,

2003-09-19  Tor Lillqvist  <tml@iki.fi>

* gdk/win32/gdkkeys-win32.c (update_keymap): Handle dead keysyms
present on the US-International keyboard. For clarity, order
keysyms in case statement according to numeric value.

(gdk_keymap_translate_keyboard_state): Handle Caps Lock
correctly. (#120176, Ken Rastatter and Owen Taylor)

22 years agoUpdated Serbian translation.
Danilo Šegan [Thu, 18 Sep 2003 21:24:04 +0000 (21:24 +0000)]
Updated Serbian translation.

2003-09-18  Danilo Šegan  <dsegan@gmx.net>

* sr.po, sr@Latn.po: Updated Serbian translation.

22 years ago0.4.2
Raymond Penners [Thu, 18 Sep 2003 19:30:06 +0000 (19:30 +0000)]
0.4.2

22 years agoCall g_closure_unref() to unref a closure, not g_object_unref(). (#122637,
Matthias Clasen [Thu, 18 Sep 2003 19:04:42 +0000 (19:04 +0000)]
Call g_closure_unref() to unref a closure, not g_object_unref(). (#122637,

2003-09-18  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkaction.c (gtk_action_finalize): Call g_closure_unref() to
unref a closure, not g_object_unref().  (#122637, Marco Pesenti Gritti)

22 years agoInstall accelerators on actions, not on proxies, support accelerator-only
Matthias Clasen [Wed, 17 Sep 2003 23:58:28 +0000 (23:58 +0000)]
Install accelerators on actions, not on proxies, support accelerator-only

2003-09-18  Matthias Clasen  <maclas@gmx.de>

Install accelerators on actions, not on proxies, support
accelerator-only actions:

* gtk/gtkmenu.c (get_accel_path): New function to get the accel path
and its lock status either via _gtk_widget_get_accel_path() or by
looking at the accel_path stored in the menu item itself and determining
its lock status by peeking into the contained accel label. This was
already (accidentally) committed a week ago.

* gtk/gtkaction.h (gtk_action_set_accel_group):
(gtk_action_[dis]connect_accelerator): New functions.

* gtk/gtkaction.c (struct _GtkActionPrivate): Add accel_group,
accel_closure and accel_count. We must have a reference to the accel_group,
since we need it in connect_proxy. The count is necessary to ensure
that the accelerator isn't removed before the last proxy requesting
it has been unmerged.
(connect_proxy): Connect the accelerator to the
action now, only set the accel_path on the menuitem.
(remove_proxy): Disconnect the accelerator from the action, not from
the menuitem.
(gtk_action_set_accel_group): Set the accel group.
(gtk_action_[dis]connect_accelerator): Count the number of times
this functions have been called and install/remove the accelerator if
the count leaves/reaches zero.

* gtk/gtkuimanager.h (GtkUIManagerItemType): Add
GTK_UI_MANAGER_ACCELERATOR.

* gtk/gtkuimanager.c (NodeType): Add NODE_TYPE_ACCELERATOR.
(start_element_handler): Create NODE_TYPE_ACCELERATOR nodes from
<accelerator> elements.
(gtk_ui_manager_add_ui): Create NODE_TYPE_ACCELERATOR nodes when
type is GTK_UI_MANAGER_ACCELERATOR.
(update_node): Set the accel group on actions before creating their
proxies. Don't set the accel group on created menus. For
NODE_TYPE_ACCELERATOR nodes, [dis]connect the actions' accelerator.
(print_node): Also emit <accelerator> elements.

* tests/testmerge.c (dump_accels): Add a "Dump Accels" button.

22 years agoRobustness improvements.
Matthias Clasen [Wed, 17 Sep 2003 22:44:01 +0000 (22:44 +0000)]
Robustness improvements.

* gtk/gtkuimanager.c (update_node): Robustness improvements.

22 years agoReport unexpected character data as error from the GMarkup parser,
Matthias Clasen [Wed, 17 Sep 2003 19:18:45 +0000 (19:18 +0000)]
Report unexpected character data as error from the GMarkup parser,

2003-09-17  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkuimanager.c (text_handler): Report unexpected character
data as error from the GMarkup parser, otherwise things like
gtk_ui_manager_add_ui_from_string (ui, "Hi there!", -1, &error)
pass unexpectedly.

22 years agorevert accidentally committed !redraw_on_allocate change.
Soeren Sandmann [Wed, 17 Sep 2003 00:49:45 +0000 (00:49 +0000)]
revert accidentally committed !redraw_on_allocate change.

Wed Sep 17 02:38:53 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktoolbar.c (gtk_toolbar_class_init): revert accidentally
committed !redraw_on_allocate change.

22 years agoAdd gdk_window_set_keep_{above,below} stubs to fix compilation
Eric Warmenhoven [Tue, 16 Sep 2003 17:59:20 +0000 (17:59 +0000)]
Add gdk_window_set_keep_{above,below} stubs to fix compilation

Tue Sep 16 10:42:00 2003  Eric Warmenhoven  <eric@warmenhoven.org>

        * gdk/linux-fb/gdkwindow-fb.c: Add gdk_window_set_keep_{above,below}
        stubs to fix compilation

        * gdk/linux-fb/gdkrender-fb.c: Add gdk_shadow_fb_stop_updates stub for
        when shadowfb is disabled. Patch from pjm@cctechnol.com (#120847).

        * gdk/linux-fb/gdkmouse-fb.c: Add GDK_MOUSE_DEVICE environment
        variable. Patch from Marc Welz (#121347).

22 years agoignore clip rect for now
cinamod [Tue, 16 Sep 2003 13:36:20 +0000 (13:36 +0000)]
ignore clip rect for now

22 years agoApply egtk-format-protos. Doc tweaks.
Matthias Clasen [Mon, 15 Sep 2003 22:21:26 +0000 (22:21 +0000)]
Apply egtk-format-protos. Doc tweaks.

* gtk/gtkaction.h: Apply egtk-format-protos.
* gtk/gtkuimanager.c: Doc tweaks.

* gtk/tmpl/gtkaction.sgml:
* gtk/tmpl/gtkradioaction.sgml:
* gtk/tmpl/gtkactiongroup.sgml:
* gtk/tmpl/gtkuimanager.sgml: Updates.

22 years ago0.4.1
Raymond Penners [Mon, 15 Sep 2003 20:53:07 +0000 (20:53 +0000)]
0.4.1

22 years agoTree expanders fixed
Raymond Penners [Mon, 15 Sep 2003 20:52:37 +0000 (20:52 +0000)]
Tree expanders fixed

22 years agoNew function which implements "smart" separators by iterating once over
Matthias Clasen [Mon, 15 Sep 2003 20:35:28 +0000 (20:35 +0000)]
New function which implements "smart" separators by iterating once over

* gtk/gtkuimanager.c (update_smart_separators): New function which
implements "smart" separators by iterating once over the entries of a
menu, hiding and showing separators as necessary.
(update_node): Mark separators used as fences of placeholders as
hidden. Explicitly added separators are marked as smart. Call
update_smart_separators after updating a menu or toolbar node.
Connect update_smart_separators to "notify::visible" signal on menu
and tool items.

* tests/merge-[12].ui: Test smart separators.

* gtk/tmpl/gtkuimanager.sgml: Add a paragraph about smart separators.

22 years agoAdd value parameter to allow setting the currently selected group member
Matthias Clasen [Mon, 15 Sep 2003 19:51:55 +0000 (19:51 +0000)]
Add value parameter to allow setting the currently selected group member

2003-09-15  Matthias Clasen  <maclas@gmx.de>

* gtk/gtkactiongroup.[hc]: (gtk_action_group_add_radio_actions):
(gtk_action_group_add_radio_actions_full): Add value parameter to allow
setting the currently selected group member before connecting signals.
(GtkToggleActionEntry): Separate struct for constructing toggle actions,
including a boolean to initialize the action state before connecting
signals.
(gtk_action_group_add_toggle_actions):
(gtk_action_group_add_toggle_actions_full): New functions to construct
toggle actions from an array of GtkToggleActionEntries.

* demos/gtk-demo/appwindow.c:
* tests/testactions.c:
* tests/testmerge.c: Adjust to new action group API.

* gtk/gtk-sections.txt: Add gtk_action_group_add_toggle_actions[_full].

22 years agoSeveral last-minute fixes
Raymond Penners [Mon, 15 Sep 2003 17:58:44 +0000 (17:58 +0000)]
Several last-minute fixes

22 years agoimplement caret blink
cinamod [Mon, 15 Sep 2003 14:02:23 +0000 (14:02 +0000)]
implement caret blink

22 years agoUpdated Japanese translation.
KAMAGASAKO Masatoshi [Mon, 15 Sep 2003 13:22:52 +0000 (13:22 +0000)]
Updated Japanese translation.

2003-09-15  KAMAGASAKO Masatoshi  <emerald@gnome.gr.jp>

* ja.po: Updated Japanese translation.

22 years agoavoid crash when selecting a new filter and clicking a different directory
Bastien Nocera [Mon, 15 Sep 2003 10:27:05 +0000 (10:27 +0000)]
avoid crash when selecting a new filter and clicking a different directory

2003-09-15  Bastien Nocera  <hadess@hadess.net>

* gtkfilefilter.c: (gtk_file_filter_filter): avoid crash when
selecting a new filter and clicking a different directory

22 years agoConsole error messages
Raymond Penners [Sun, 14 Sep 2003 18:54:00 +0000 (18:54 +0000)]
Console error messages

22 years agoName the arrow "gtk-toolbar-arrow" so themes can special-case it.
Soeren Sandmann [Sun, 14 Sep 2003 15:03:07 +0000 (15:03 +0000)]
Name the arrow "gtk-toolbar-arrow" so themes can special-case it.

Sun Sep 14 16:59:52 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktoolbar.c (gtk_toolbar_init): Name the arrow
"gtk-toolbar-arrow" so themes can special-case it.

22 years agosort the list of files.
Soeren Sandmann [Sun, 14 Sep 2003 14:09:37 +0000 (14:09 +0000)]
sort the list of files.

Sun Sep 14 16:07:49 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/Makefile.am (gtk_c_sources): sort the list of files.

22 years agoUnref the PangoFontMetrics. Patch from Steve Chaplin (#122257).
Soeren Sandmann [Sun, 14 Sep 2003 13:51:27 +0000 (13:51 +0000)]
Unref the PangoFontMetrics. Patch from Steve Chaplin (#122257).

Sun Sep 14 15:49:00 2003  Soeren Sandmann  <sandmann@daimi.au.dk>

* gtk/gtktoolbar.c (toolbar_item_is_homogeneous): Unref the
PangoFontMetrics. Patch from Steve Chaplin (#122257).

22 years agoRemove special-case code for WS_EX_TRANSPARENT (GDK_INPUT_ONLY) windows,
Tor Lillqvist [Sun, 14 Sep 2003 13:43:45 +0000 (13:43 +0000)]
Remove special-case code for WS_EX_TRANSPARENT (GDK_INPUT_ONLY) windows,

2003-09-14  Tor Lillqvist  <tml@iki.fi>

* gdk/win32/gdkwindow-win32.c (show_window_internal): Remove
special-case code for WS_EX_TRANSPARENT (GDK_INPUT_ONLY) windows,
the usefulness of which was already in doubt. Removing it fixes
bugs #118575 and #121851.

22 years agosf bug 805259
Raymond Penners [Sun, 14 Sep 2003 09:47:25 +0000 (09:47 +0000)]
sf bug 805259

22 years agoMerge from stable.
Jonathan Blandford [Fri, 12 Sep 2003 14:46:50 +0000 (14:46 +0000)]
Merge from stable.

Fri Sep 12 16:32:53 2003  Jonathan Blandford  <jrb@redhat.com>

Merge from stable.

* gtk/gtktreeview.c (gtk_tree_view_button_press): only save the
pressed button (used to determine if we want to initiate a drag later
on) if the current grab widget is either NULL or tree_view (Reported
by Jeroen Zwartepoorte).

22 years agoAdd deprecation notes. (#121955)
Matthias Clasen [Thu, 11 Sep 2003 22:09:38 +0000 (22:09 +0000)]
Add deprecation notes. (#121955)

2003-09-12  Matthias Clasen  <maclas@gmx.de>

* gdk/gdkdraw.c (gdk_draw_string, gdk_draw_text)
(gdk_draw_text_wc): Add deprecation notes.  (#121955)

22 years agoAdd table menu tests.
Matthias Clasen [Thu, 11 Sep 2003 21:02:24 +0000 (21:02 +0000)]
Add table menu tests.

2003-09-11  Matthias Clasen  <maclas@gmx.de>

* tests/testgtk.c: Add table menu tests.

* gtk/gtkmenu.c (gtk_menu_free_private): Don't forget to free the
GtkMenuPrivate struct itself. Pointed out by valgrind.

* gtk/gtkuimanager.c (gtk_ui_manager_finalize): Clean up
properly.  (#121998)

22 years agofix gtkrc
cinamod [Thu, 11 Sep 2003 19:22:01 +0000 (19:22 +0000)]
fix gtkrc

22 years ago0.4.0
Raymond Penners [Thu, 11 Sep 2003 18:51:05 +0000 (18:51 +0000)]
0.4.0

22 years agoNotebook regression fixed
Raymond Penners [Thu, 11 Sep 2003 18:44:39 +0000 (18:44 +0000)]
Notebook regression fixed

22 years agoAdded an API point about needing a way to fetch the hpaned position so we
Federico Mena Quintero [Thu, 11 Sep 2003 00:56:46 +0000 (00:56 +0000)]
Added an API point about needing a way to fetch the hpaned position so we

2003-09-10  Federico Mena Quintero  <federico@ximian.com>

* TODO: Added an API point about needing a way to fetch the hpaned
position so we can save it.

* gtkfilechooser.c (_gtk_file_chooser_get_paths): Fixed API docs.
(gtk_file_chooser_get_uris): Likewise.
(gtk_file_chooser_get_filenames): Likewise.

* gtkfilechooserdialog.c (file_chooser_widget_file_activated): New
callback, calls gtk_window_activate_default().

* testfilechooser.c (response_cb): Print the selected files if the
user clicks OK.

22 years agoConnect to "row_activated" on the file list. (list_row_activated): New
Federico Mena Quintero [Thu, 11 Sep 2003 00:33:28 +0000 (00:33 +0000)]
Connect to "row_activated" on the file list. (list_row_activated): New

2003-09-10  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (create_file_list): Connect to
"row_activated" on the file list.
(list_row_activated): New function.  Changes to folders or emits
the "file-activated" signal depending on what type of row was
activated.
(create_folder_tree): Renamed from create_directory_tree(), since
"folder" is the new politically-correct name.

* gtkfilechooserprivate.h (struct _GtkFileChooserIface): Added a
file-activated signal.

* gtkfilechooser.c (gtk_file_chooser_class_init): Register the
signal.

* gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Connect
to "file-activated" on the delegate.
(delegate_file_activated): New function.

* TODO: Added an API item about Clipart-like folders provided by
applications.

22 years agoThe table menu patch! Turns GtkMenu into a table, so you can attach menu
Kristian Rietveld [Wed, 10 Sep 2003 20:32:33 +0000 (20:32 +0000)]
The table menu patch! Turns GtkMenu into a table, so you can attach menu

Wed Sep 10 22:25:04 2003  Kristian Rietveld  <kris@gtk.org>

The table menu patch! Turns GtkMenu into a table, so you can attach
menu items in numerous new ways! Be creative!

Contains some bug fixes and RTL adaptions from Matthias Clasen.

* gtk/gtkmenu.c [toplevel]: introduce ATTACH_INFO_KEY, extend
GtkMenuPrivate, introduce AttachInfo, add child properties enum,
(gtk_menu_free_private), (gtk_menu_get_private): we have to free
the heights array in the private struct,
(gtk_menu_class_init): reorder code a bit, install child properties,
(get_attach_info), (get_child_attach): new utility functions,
(gtk_menu_set_child_property), (gtk_menu_get_child_property): introduce
child properties, for the attach info,
(gtk_menu_remove): remove AttachInfo from menu item,
(gtk_menu_real_insert): implemented algorithm to automagically place
inserted menu items at the correct place in the table,
(gtk_menu_size_request), (gtk_menu_size_allocate),
(compute_child_offset): reworked/rewritten to support table menus,
(gtk_menu_attach): new function,
(find_child_containing), (gtk_menu_move_current): new functions to
get table menu keynav right.

* gtk/gtkmenu.h: add gtk_menu_attach() prototype.

22 years agoOnly remove PropertyNotify events from the stream if they have been
Matthias Clasen [Wed, 10 Sep 2003 15:56:11 +0000 (15:56 +0000)]
Only remove PropertyNotify events from the stream if they have been

2003-09-10  Matthias Clasen  <maclas@gmx.de>

* gtk/gtksocket.c (gtk_socket_filter_func): Only remove
PropertyNotify events from the stream if they have been handled,
in order to enable extending the plug<->socket communication via
properties.

22 years agoUse the cell renderer's "text" and "weight" properties rather than
Federico Mena Quintero [Wed, 10 Sep 2003 01:26:13 +0000 (01:26 +0000)]
Use the cell renderer's "text" and "weight" properties rather than

2003-09-09  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (set_cell_text_bold_if_folder): Use
the cell renderer's "text" and "weight" properties rather than
"markup".

22 years agoBig TreeView DnD fixage, makes drops on empty models work, makes TreeStore
Kristian Rietveld [Tue, 9 Sep 2003 23:13:39 +0000 (23:13 +0000)]
Big TreeView DnD fixage, makes drops on empty models work, makes TreeStore

Wed Sep 10 01:06:44 2003  Kristian Rietveld  <kris@gtk.org>

Big TreeView DnD fixage, makes drops on empty models work, makes
TreeStore DnD work and gets rid of gtk-tree-model-drop-append.
Related bugs #95362 and #113314. I don't want to touch this code
ever again.

* gtk/gtktreeprivate.h (GtkTreePrivate): add empty_view_drop field.

* gtk/gtktreednd.c (gtk_tree_get_row_drag_data): add check
for selection_data->length.

* gtk/gtktreeview.c (struct DestRow), (dest_row_free),
(set_dest_row), (get_dest_row): we don't store just the row ref
anymore, but a struct with the row ref and additional info,
(set_destination_row): handle drops on empty space and some
style fixes,
(get_logical_dest_row): also return path_down_mode/drop_append_mode
flags, handle dropping childs on their new parents, rewrite
drop append handling into something saner,
(gtk_tree_view_drag_motion): show a "drop possible arrow" on empty
spaces,
(gtk_tree_view_drag_drop): updates for updated backend,
(gtk_tree_view_drag_data_received): updates for updated backend,
path down mode (treestore DnD) handling,
(gtk_tree_view_set_drag_dest_row): set empty_view_drop flag,
when we are trying to drop a row on an empty model,
(gtk_tree_view_get_drag_dest_row): handle empty_view_drop flag.

* gtk/gtkliststore.c (gtk_list_store_drag_data_received),
(gtk_list_store_row_drop_possible): style and drop-append fixes.

* gtk/gtktreestore.c (gtk_tree_store_drag_data_received): ditto.

22 years agoMake the list model read in directory information as well.
Federico Mena Quintero [Tue, 9 Sep 2003 17:50:23 +0000 (17:50 +0000)]
Make the list model read in directory information as well.

2003-09-09  Federico Mena Quintero  <federico@ximian.com>

* gtkfilechooserimpldefault.c (tree_selection_changed): Make the
list model read in directory information as well.
(set_cell_text_bold_if_folder): New utility function.  Sets a
cell's text, making it bold if the file info is a folder.
(list_name_data_func): Use set_cell_text_bold_if_folder().
(list_mtime_data_func): Use set_cell_text_bold_if_folder().
(list_size_data_func): Don't set anything if the file info is a
folder.

22 years agoSmall doc fix
Owen Taylor [Tue, 9 Sep 2003 15:37:54 +0000 (15:37 +0000)]
Small doc fix